docs: s2s reconnect advice - #20
Open
infiniteregrets wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
shikhar
reviewed
Aug 14, 2026
| A server that is about to terminate sets the reconnect-advised flag on regular messages. The message body is unchanged, so clients that ignore the flag keep working. | ||
|
|
||
| * **Read** sessions should be re-established with a fresh request. | ||
| * **Append** sessions should stop sending inputs and half-close the request stream. The server acknowledges all accepted inputs and then ends the session cleanly. |
Member
There was a problem hiding this comment.
I think this is missing the complete picture for clients, who also need to establish a new session to start using once all acks for in-flight appends have been received. Establishing the new session can happen concurrently.
shikhar
reviewed
Aug 14, 2026
shikhar
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the reconnect-advised bit in the S2S flag byte and the graceful shutdown contract:
A): server sets it on regular messages before terminating. Body is unchanged, so clients that ignore the bit keep working.503codeserver_draining. Acknowledgements always precede the terminal message, so unresolved inputs can be safely resubmitted on a new session.Matches the protocol additions released in s2-api 0.31.1 (s2-streamstore/s2#700).
🤖 Generated with Claude Code