Skip to content

Version 2 - #255

Draft
kennarddh wants to merge 88 commits into
samayo:masterfrom
kennarddh:feat/v2
Draft

kennarddh wants to merge 88 commits into
samayo:masterfrom
kennarddh:feat/v2

Conversation

@kennarddh

@kennarddh kennarddh commented Aug 7, 2023 •

Copy link
Copy Markdown

To Do

  • Define Data Structure
    • ISO3166
    • Average Height
    • UnitedNationsMember
    • Countries name
    • GS1Code
    • Calling codes
    • Capital cities
    • Cities
    • Continent
    • Coastline
    • Area
    • ISO4217 code
    • Currency symbol
    • Currency name
    • ccTLD
    • Average elevation
    • Flag
    • Geo cordinates
    • Government
    • Independence
    • Landlocked
    • Languages
    • Life expectancy
    • National dishes
    • National symbol
    • Population density
    • Population
    • Regions
    • Religion
    • Average yearly temperature
    • National sports
  • Scrap data
    • ISO3166
    • Average Height
    • UnitedNationsMember
    • Countries name
    • GS1Code
    • Calling codes
    • Capital cities
    • Cities
    • Continent
    • Coastline
    • Area
    • ISO4217 code
    • Currency symbol
    • Currency name
    • ccTLD
    • Average elevation
    • Flag
    • Geo cordinates
    • Government
    • Independence
    • Landlocked
    • Languages
    • Life expectancy
    • National dishes
    • National symbol
    • Population density
    • Population
    • Regions
    • Religion
    • Average yearly temperature
    • National sports

Proposed Changes

Update

  • This will be very big breaking change.
  • This will also increase the data size as more fields and data is added.
  • To reduce size we can remove null value. Like if the country doesn't have the data instead of null we delete the data to reduce size. API library can solve this to return null instead of error when getting the data.
  • Data maybe cannot be modified manually as its will be overridden every month.
  • Data will scrapped mostly from wikipedia and wikimedia. I still can't find some data.
  • Boolean will be used instead of string 1 or 0
  • Periodic update will create new pull request and still need to be reviewed manually every month. To prevent if wikipedia changed its page html structure.

Removed

  • Alphabet Letters: Do we need this data, this seems redundant.
  • ISO Numeric: Merge with ISO3166

Added

  • UnitedNationsMember data
  • Currency symbol
  • National sport
  • ISO3166
  • Many new fields

Changed

  • Change Barcode prefix to GS1Code
  • Rename Country By Abbreviation to ISO3166. Add 2 and 3 letter code.
  • Rename Currency code to ISO4217.
  • Average Height
  • Rename Domain tld to ccTLD and add new fields.
  • Rename elevation to averageElevation
  • Rename independence date to independence
  • Rename government type to government
  • Rename Capital City to Capital Cities: Country can have multiple capital cities

Source

Note

@kennarddh kennarddh mentioned this pull request Aug 7, 2023
@samayo

samayo commented May 5, 2024

Copy link
Copy Markdown
Owner

hey, do you need help with this? if so please let me know. if you don't have time then it's ok we can save it for future tasks

@kennarddh

Copy link
Copy Markdown
Author

Oh, I kind of forgot about this repo, haven't checked my Github notification for a month.
But I think I can continue this after I'm done with my current project.
Also if you want to help, sure.

@samayo

samayo commented May 17, 2024

Copy link
Copy Markdown
Owner

Oh, I kind of forgot about this repo, haven't checked my Github notification for a month. But I think I can continue this after I'm done with my current project. Also if you want to help, sure.

I can help, as long as you tell me where you need one

@kennarddh

Copy link
Copy Markdown
Author

You can add scripts to scrap the remaining data from wikipedia or wikimedia I think.

Also ping me if you reply so I can get email notification @kennarddh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants