Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new "Quick Share" feature, allowing the app to receive files from nearby devices. It adds the necessary infrastructure for enabling/disabling this feature, updates settings and UI components to reflect its state, and removes the legacy
ShareActivityin favor of a new approach. Additionally, it integrates the Wire library for protocol buffer support and makes minor improvements to the About section and quick settings tiles.Quick Share Feature Integration:
quick_share_enabledpreference inDataStoreManagerwith corresponding methods to set and observe its value, and updated the repository interface and implementation to expose these methods. (app/src/main/java/com/sameerasw/airsync/data/local/DataStoreManager.kt[1] [2];app/src/main/java/com/sameerasw/airsync/domain/repository/AirSyncRepository.kt[3];app/src/main/java/com/sameerasw/airsync/data/repository/AirSyncRepositoryImpl.kt[4]UiStateto includeisQuickShareEnabled, and ensured theAirSyncViewModelobserves and updates this state, including initial state setup. (app/src/main/java/com/sameerasw/airsync/domain/model/UiState.kt[1];app/src/main/java/com/sameerasw/airsync/presentation/viewmodel/AirSyncViewModel.kt[2] [3] [4]app/src/main/java/com/sameerasw/airsync/presentation/ui/components/SettingsView.kt[1] [2];app/src/main/java/com/sameerasw/airsync/presentation/ui/components/cards/QuickSettingsTilesCard.kt[3];app/src/main/java/com/sameerasw/airsync/presentation/ui/composables/WelcomeScreen.kt[4]QuickShareServicein the Android manifest to handle incoming Quick Share requests. (app/src/main/AndroidManifest.xmlapp/src/main/AndroidManifest.xmlR176-R180)Removal of Legacy Sharing Activity:
ShareActivityclass and its manifest entry, as Quick Share replaces the old sharing mechanism. (app/src/main/java/com/sameerasw/airsync/presentation/ui/activities/ShareActivity.kt[1];app/src/main/AndroidManifest.xml[2]Build System and Library Updates:
app/build.gradle.kts[1] [2]UI and About Section Improvements:
app/src/main/java/com/sameerasw/airsync/presentation/ui/components/AboutSection.kt[1] [2]Manifest and Permissions:
app/src/main/AndroidManifest.xml[1] [2]