Point live references at samrusani/AliceMemory - #363
Merged
Conversation
Sweeps the 45 live occurrences of the old repository slug. The GitHub rename makes the old name redirect, so nothing here is broken today, but a redirect is not a permanent guarantee: it stops the moment anyone creates a repository at the freed name. Priority within the sweep was by blast radius rather than count. scripts/install-ubuntu.sh line 4 and the raw curl in the headless install guide are the two whose worst case is a user downloading and executing a script from a path we no longer control, rather than following a wrong link. pyproject.toml and docs/pypi-description.md are the two halves of the PyPI page and are frozen into every wheel at build time, so they move together. Nine occurrences are deliberately left alone, all under docs/release/ and docs/archive/. Those artifacts were built and signed from samrusani/AliceBot, and PyPI's attestations bind the bytes to that slug permanently: the certs embed it in the subject and cannot be edited. Rewriting a release note to say AliceMemory would put the document in direct conflict with the signed provenance for the artifact it describes. A changelog line records the rename instead, which orients a reader without falsifying the record. Also corrects four references to systemd units that do not exist. packaging ships alice-api.service, alice-scheduler.service and alice-web.service, while the single-tenant deployment guide named alicebot-api.service and the vNext local-runtime guide named alicebot-vnext-scheduler.service. Both would send a self-hoster chasing units that were never installed. Unrelated to the rename, found while checking it, fixed here because it is the same naming confusion. The Python module, console scripts, database roles and install paths are unchanged and are not in scope. The module alone is 2,299 imports across 464 files plus a sys.modules aliasing shim that hardcodes the string "alicebot_api.contracts", for no benefit a user can see. Verified: 4541 unit passed, 2 skipped. The deployment guard sentence that the unit gate and the smoke script both pin by literal substring is untouched.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
samrusani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on the GitHub rename. Merging this before the repo is renamed makes 45 links 404.
Order is: add the new PyPI publisher, rename the repo on GitHub, then merge this.
What this does
Sweeps the 45 live occurrences of
samrusani/AliceBot. Priority was by blast radius, not count:scripts/install-ubuntu.sh:4and the raw curl in the headless install guide are the two whose worst case is a user executing a script from a path we no longer controlpyproject.tomlanddocs/pypi-description.mdare the two halves of the PyPI page, frozen into every wheel at build timeWhat it deliberately leaves alone
Nine occurrences under
docs/release/anddocs/archive/. Those artifacts were built and signed fromsamrusani/AliceBot, and PyPI's Sigstore attestations bind the bytes to that slug permanently. Rewriting a release note to say AliceMemory would put the document in direct conflict with the signed provenance for the artifact it describes. ACHANGELOG.mdline records the rename instead.Bonus fix, unrelated to the rename
Four references to systemd units that do not exist. We ship
alice-api.service,alice-scheduler.service,alice-web.service; the deployment guide namedalicebot-api.serviceand the vNext local-runtime guide namedalicebot-vnext-scheduler.service. Both would send a self-hoster chasing units that were never installed.Not in scope
The
alicebot_apimodule, console scripts, database roles, install paths. The module alone is 2,299 imports across 464 files plus asys.modulesaliasing shim hardcoding"alicebot_api.contracts", for zero user-visible benefit.Verification
4541 unit passed, 2 skipped. The
Remote /v1 is unsupportedsentence that both the unit gate and the deployment smoke script pin by literal substring is untouched.