Skip to content

add ecdsa support for native client#69

Draft
ruslandoga wants to merge 2 commits into
sasa1977:masterfrom
ruslandoga:ecdsa
Draft

add ecdsa support for native client#69
ruslandoga wants to merge 2 commits into
sasa1977:masterfrom
ruslandoga:ecdsa

Conversation

@ruslandoga

@ruslandoga ruslandoga commented Jun 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #65

  • fix tests
  • try it manually to make sure it works
  • ensure existing rsa keys are renewed with the same key_alg=rsa
  • add configuration options for certbot client?
  • add tests

ruslandoga
ruslandoga commented Jun 30, 2024
View reviewed changes
Comment thread lib/site_encrypt.ex
],
elliptic_curve: [
type: {:in, ["P-256", "P-384"]},
default: "P-256",

@ruslandoga ruslandoga Jun 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P-256 is fast: benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for ECDSA certificates in the native client

1 participant

@ruslandoga