Repository navigation
feat(lsp): getting macro parameters when using ctrl space for custom macros(2129) - #2130
kailas-late wants to merge 18 commits into
Conversation
ceb247a to
edffb35
Compare
edffb35 to
d68778b
Compare
ksurajofficial
left a comment
There was a problem hiding this comment.
I'd also suggest getting feedback from @2TomLi , since this is specific to the code editor.
…macros(2129) Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
d68778b to
b2c4760
Compare
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
8fe3218 to
90f22d4
Compare
|
Thanks, Kailas, for addressing my queries! Overall, looks good to me. Just one request for a separate doc ticket once testing is complete and the PR is merged: this looks like a good candidate to be part of the documentation, so could you add a GIF of this feature under "Code Completion" in sasCodeEditing? |
90f22d4 to
c33ac00
Compare
…macros(2129) Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
c33ac00 to
613e0a6
Compare
…ension into pr-issue-2129
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
Signed-off-by: Kailas Late <dvklate@gmail.com>
|
Thanks again, @ksurajofficial and @yououhan123, for the review, and apologies for the confusion around the scope. After revisiting the requirements today, I realized that the consumer's requirements cover individual files only, so cross-file/workspace handling is outside the scope of this PR. I've aligned the implementation accordingly. Could you please take another look when you get a chance? I'd be happy to address any further feedback. |
Summary:
This PR adds support for providing parameter information and signature help for custom SAS macros when using Ctrl + Space in the editor.
Key changes:
Resolves #2129.
Testing:
How did you test this change?
TODOs: