Skip to content

fix: close table and property viewers on delete - #2175

Merged
noahhowell117 merged 2 commits into
mainfrom
pr-nohowe-2163-1
Nov 13, 2026
Merged

noahhowell117 merged 2 commits into
mainfrom
pr-nohowe-2163-1

Conversation

@noahhowell117

@noahhowell117 noahhowell117 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary:
Changes to close a table viewer and/or table properties viewer whenever the table is deleted. Updated new delete key tests to account for this change.

Testing:

  1. Connect to a SAS profile and expand Libraries > WORK.
  2. Create a table (e.g., data a; x=1; run;).
  3. Open the table in the data viewer and/or its table properties (right-click the table and select properties).
  4. Right-click the table in the Libraries pane and choose Delete, then confirm.
  5. The opened table viewer and/or properties viewer should now close.

TODOs:

  • Add any supporting documentation and (optionally) update CHANGELOG.md

@noahhowell117 noahhowell117 self-assigned this Nov 11, 2026
Signed-off-by: Noah Howell <nhowell117@gmail.com>
Signed-off-by: Noah Howell <nhowell117@gmail.com>
@noahhowell117 noahhowell117 linked an issue Nov 11, 2026 that may be closed by this pull request
1 task done
@noahhowell117
noahhowell117 marked this pull request as ready for review November 11, 2026 22:07
@noahhowell117
noahhowell117 requested a review from a team as a code owner November 11, 2026 22:07

@ksurajofficial ksurajofficial left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noahhowell117 noahhowell117 added the ready for test PR is ready for testing (before merge) label Nov 12, 2026
@grantfountain-projs grantfountain-projs added in test Tester is testing the PR branch ready for merge PR branch testing is done and removed ready for test PR is ready for testing (before merge) in test Tester is testing the PR branch labels Nov 12, 2026
@noahhowell117
noahhowell117 merged commit 1619a67 into main Nov 13, 2026
2 checks passed
@noahhowell117
noahhowell117 deleted the pr-nohowe-2163-1 branch November 13, 2026 14:16
@noahhowell117 noahhowell117 added ready for verification Merged, needs checking on main and removed ready for merge PR branch testing is done labels Nov 13, 2026
@grantfountain-projs grantfountain-projs added in verification Tester is verifying on the main branch verified Confirmed on main and removed ready for verification Merged, needs checking on main in verification Tester is verifying on the main branch labels Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

verified Confirmed on main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open table viewer stays open after the table is deleted

4 participants