add tests for server side encryption, file backend encryption only by SylvainSenechal · Pull Request #2369 · scality/Zenko

SylvainSenechal · 2026-03-30T16:11:40Z

bert-e · 2026-03-30T16:11:45Z

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-03-30T16:14:23Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

tests/ctst/features/serverSideEncryption.feature

SylvainSenechal · 2026-03-31T09:59:23Z

tests/ctst/features/serverSideEncryption.feature

+        And bucket encryption is set to "<bucketAlgo>" with key "<bucketKeyId>"
+        Then the bucket encryption is verified for algorithm "<bucketAlgo>" and key "<bucketKeyId>"
+        When an object "<objectName>" is uploaded with SSE algorithm "<objectAlgo>" and key "<objectKeyId>"
+        # TODO: uncomment when CloudServer returns SSE headers in PutObject response https://github.com/scality/cloudserver/pull/6122


I have other pr coming later, I can wait now, or uncomment later in another pr, because we need to wait for a cloudserver release

should this PR before before cloudserver PR, or does it need to be updated?

the cloudserver pr is merged, but cloudserver is not bumped yet, we need a new version of cloudserver

cloudserver is released, no need to comment this anymore

then you need to rebase on top of https://github.com/scality/Zenko/tree/refs/heads/w/2.14/improvement/ZENKO-5242, otherwise you don't have the bump yet...

SylvainSenechal · 2026-03-31T10:08:21Z

tests/ctst/features/serverSideEncryption.feature

+    @PreMerge
+    @ServerSideEncryption
+    @ServerSideEncryptionFileBackend
+    Scenario Outline: PutObject with invalid SSE parameters returns an error: <objectName>


These last 3 scenarios are maybe not so relevant for functional tests, test in cloudserver would probably be enough but I guess its fine

Can you double check we have the tests in Cloudserver, though?

half of them are covered, so yeah it's very moderately useful

so half are not covered : can you create a ticket in cloudserver?

SylvainSenechal · 2026-03-31T10:09:16Z

tests/ctst/steps/serverSideEncryption.ts

+import Zenko from 'world/Zenko';
+import assert from 'assert';
+
+// We use the AWS SDK directly instead of cli-testing for PutObject and GetObject


This is more annoying than I thought, even later if we wanna parallelize coldStorage test, one of the test is using getObject..

tests/ctst/features/serverSideEncryption.feature

francoisferrand · 2026-04-01T07:33:50Z

tests/ctst/features/serverSideEncryption.feature

+        And bucket encryption is set to "<bucketAlgo>" with key "<bucketKeyId>"
+        Then the bucket encryption is verified for algorithm "<bucketAlgo>" and key "<bucketKeyId>"
+        When an object "<objectName>" is uploaded with SSE algorithm "<objectAlgo>" and key "<objectKeyId>"
+        # TODO: uncomment when CloudServer returns SSE headers in PutObject response https://github.com/scality/cloudserver/pull/6122


should this PR before before cloudserver PR, or does it need to be updated?

tests/ctst/features/serverSideEncryption.feature

francoisferrand · 2026-04-01T07:35:43Z

tests/ctst/features/serverSideEncryption.feature

+    @PreMerge
+    @ServerSideEncryption
+    @ServerSideEncryptionFileBackend
+    Scenario Outline: PutObject with invalid SSE parameters returns an error: <objectName>


Can you double check we have the tests in Cloudserver, though?

tests/ctst/steps/serverSideEncryption.ts

delthas · 2026-04-01T07:41:06Z

tests/ctst/steps/serverSideEncryption.ts

+        // TODO: uncomment when merged and released : https://github.com/scality/cloudserver/pull/6122
+        // => CloudServer will return SSE headers in PutObject response
+        // if (expectedAlgo) {
+        //     assert.strictEqual(result.serverSideEncryption, expectedAlgo,
+        //         `PutObject SSE: expected "${expectedAlgo}", got "${result.serverSideEncryption}"`);
+        // } else {
+        //     assert.strictEqual(result.serverSideEncryption, undefined,
+        //         `PutObject SSE: expected absent, got "${result.serverSideEncryption}"`);
+        // }
+        // if (expectedKey === 'present') {
+        //     assert.ok(result.sseKmsKeyId, 'PutObject: SSEKMSKeyId should be present');
+        // } else {
+        //     assert.strictEqual(result.sseKmsKeyId, undefined,
+        //         `PutObject: SSEKMSKeyId should be absent, got "${result.sseKmsKeyId}"`);
+        // }


Opening a review thread so we remember to uncomment before merging.

tests/ctst/features/serverSideEncryption.feature

tests/ctst/steps/serverSideEncryption.ts

Issue: ZENKO-5239

francoisferrand · 2026-04-03T16:02:37Z

/after_pull_request=2370

bert-e · 2026-04-03T16:02:43Z

Waiting for other pull request(s)

The current pull request is locked by the after_pull_request option.

In order for me to merge this pull request, run the following actions first:

➡️ Merge the OPEN pull request:

pull request Bumps & release 2.13.10 / 2.14.2 #2370

Alternatively, delete all the after_pull_request comments from this pull request.

The following options are set: after_pull_request

scality deleted a comment from bert-e Mar 30, 2026

SylvainSenechal commented Mar 30, 2026

View reviewed changes

tests/ctst/features/serverSideEncryption.feature Show resolved Hide resolved

SylvainSenechal force-pushed the improvement/ZENKO-5239 branch from ac52225 to 7914467 Compare March 31, 2026 09:58

SylvainSenechal commented Mar 31, 2026

View reviewed changes

SylvainSenechal marked this pull request as ready for review March 31, 2026 10:09

SylvainSenechal requested review from a team, delthas and francoisferrand March 31, 2026 10:09

francoisferrand reviewed Apr 1, 2026

View reviewed changes

delthas approved these changes Apr 1, 2026

View reviewed changes

SylvainSenechal force-pushed the improvement/ZENKO-5239 branch from 7914467 to df467f1 Compare April 1, 2026 14:46

SylvainSenechal requested a review from francoisferrand April 2, 2026 08:10

SylvainSenechal force-pushed the improvement/ZENKO-5239 branch from df467f1 to 149e9ef Compare April 2, 2026 08:17

francoisferrand reviewed Apr 2, 2026

View reviewed changes

tests/ctst/features/serverSideEncryption.feature Outdated Show resolved Hide resolved

tests/ctst/steps/serverSideEncryption.ts Show resolved Hide resolved

add tests for server side encryption, file backend encryption only

0311923

Issue: ZENKO-5239

SylvainSenechal force-pushed the improvement/ZENKO-5239 branch from 149e9ef to 0311923 Compare April 3, 2026 14:40

SylvainSenechal requested a review from francoisferrand April 3, 2026 14:40

francoisferrand approved these changes Apr 3, 2026

View reviewed changes

Conversation

SylvainSenechal commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Mar 30, 2026

Hello sylvainsenechal,

Uh oh!

bert-e commented Mar 30, 2026

Waiting for approval

Uh oh!

Uh oh!

SylvainSenechal Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

francoisferrand Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal Mar 31, 2026 • edited by francoisferrand Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

francoisferrand commented Apr 3, 2026

Uh oh!

bert-e commented Apr 3, 2026

Waiting for other pull request(s)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SylvainSenechal commented Mar 30, 2026 •

edited

Loading

SylvainSenechal Mar 31, 2026 •

edited

Loading

francoisferrand Apr 3, 2026 •

edited

Loading

SylvainSenechal Mar 31, 2026 •

edited by francoisferrand

Loading