Skip to content

CLDSRV-894: Report turn-around time for PutObject and UploadPart #6153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bert-e merged 1 commit into from
Apr 17, 2026
+47 −0
Merged

CLDSRV-894: Report turn-around time for PutObject and UploadPart #6153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/api/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,19 @@ const api = {
request.serverAccessLog.analyticsUserName = authNames.userName;
}
if (apiMethod === 'objectPut' || apiMethod === 'objectPutPart') {
const setStartTurnAroundTime = () => {
if (request.serverAccessLog) {
request.serverAccessLog.startTurnAroundTime = process.hrtime.bigint();
}
};
// For 0-byte uploads, downstream handlers do not consume
// the request stream, so 'end' never fires. Set
Comment on lines +271 to +272
Copy link
Copy Markdown
Contributor

@jonathan-gramain jonathan-gramain Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, sounds like a bug at first that the request stream is not consumed, do you happen to know if there's a good reason to be so?

Copy link
Copy Markdown
Contributor Author

@dvasilas dvasilas Apr 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's an optimization:

cloudserver/lib/api/apiUtils/object/createAndStoreObject.js

Line 217 in 029b436

if (size === 0) {

// startTurnAroundTime synchronously in that case.
if (request.headers['content-length'] === '0') {
setStartTurnAroundTime();
} else {
request.on('end', setStartTurnAroundTime);
}
return next(null, userInfo, authorizationResults, streamingV4Params, infos);
}
// issue 100 Continue to the client
Expand Down
34 changes: 34 additions & 0 deletions tests/unit/api/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,40 @@ describe('api.callApiMethod', () => {
api.callApiMethod('multipartDelete', request, response, log);
});

['objectPut', 'objectPutPart'].forEach(method => {
it(`should set startTurnAroundTime on request end for ${method}`, done => {
sandbox.stub(api, method).callsFake(
(userInfo, _request, streamingV4Params, _log, cb) => {
request.on('end', () => {
assert.strictEqual(typeof request.serverAccessLog.startTurnAroundTime, 'bigint');
cb();
});
request.resume();
});
request.objectKey = 'testobject';
request.serverAccessLog = {};
api.callApiMethod(method, request, response, log, err => {
assert.ifError(err);
done();
});
});

it(`should set startTurnAroundTime synchronously for 0-byte ${method}`, done => {
sandbox.stub(api, method).callsFake(
(userInfo, _request, streamingV4Params, _log, cb) => {
assert.strictEqual(typeof request.serverAccessLog.startTurnAroundTime, 'bigint');
cb();
});
request.objectKey = 'testobject';
request.serverAccessLog = {};
request.headers = Object.assign({}, request.headers, { 'content-length': '0' });
api.callApiMethod(method, request, response, log, err => {
assert.ifError(err);
done();
});
});
});

describe('MD5 checksum validation', () => {
const methodsWithChecksumValidation = [
'bucketPutACL',
Expand Down
Loading