Skip to content

S3UTILS-228: allow custom repd port in check-replication-permissions#382

Open
nicolas2bert wants to merge 1 commit intodevelopment/1.17from
bugfix/S3UTILS-228/port
Open

S3UTILS-228: allow custom repd port in check-replication-permissions#382
nicolas2bert wants to merge 1 commit intodevelopment/1.17from
bugfix/S3UTILS-228/port

Conversation

@nicolas2bert
Copy link
Copy Markdown
Contributor

On 3-server rings, vault repd instances share hosts and bind to incremental ports (4300, 4301, …). The script had port 4300 hard-coded, so it silently connected to a follower when the leader was on another port, causing "Role not found in vault" for every bucket.

  • Parse argv[3] as ip[:port], default port to 4300 when omitted
  • Export parseLeaderAddress and add unit tests
  • Update README: CLI table, workflow examples, troubleshooting

On 3-server rings, vault repd instances share hosts and bind to
incremental ports (4300, 4301, …). The script had port 4300 hard-coded,
so it silently connected to a follower when the leader was on another
port, causing "Role not found in vault" for every bucket.

- Parse argv[3] as ip[:port], default port to 4300 when omitted
- Export parseLeaderAddress and add unit tests
- Update README: CLI table, workflow examples, troubleshooting
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 3, 2026

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 3, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-228 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.17.6

  • 1.18.0

Please check the Fix Version/s of S3UTILS-228, or the target
branch of this pull request.

@claude
Copy link
Copy Markdown

claude bot commented Apr 3, 2026

LGTM

Review by Claude Code

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.16%. Comparing base (fa6161a) to head (2169cb2).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           development/1.17     #382      +/-   ##
====================================================
+ Coverage             44.12%   44.16%   +0.04%     
====================================================
  Files                    88       88              
  Lines                  6448     6453       +5     
  Branches               1348     1349       +1     
====================================================
+ Hits                   2845     2850       +5     
  Misses                 3555     3555              
  Partials                 48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants