S3UTILS-228: allow custom repd port in check-replication-permissions#382
Open
nicolas2bert wants to merge 1 commit intodevelopment/1.17from
Open
S3UTILS-228: allow custom repd port in check-replication-permissions#382nicolas2bert wants to merge 1 commit intodevelopment/1.17from
nicolas2bert wants to merge 1 commit intodevelopment/1.17from
Conversation
On 3-server rings, vault repd instances share hosts and bind to incremental ports (4300, 4301, …). The script had port 4300 hard-coded, so it silently connected to a follower when the leader was on another port, causing "Role not found in vault" for every bucket. - Parse argv[3] as ip[:port], default port to 4300 when omitted - Export parseLeaderAddress and add unit tests - Update README: CLI table, workflow examples, troubleshooting
Contributor
Hello nicolas2bert,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
|
LGTM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/1.17 #382 +/- ##
====================================================
+ Coverage 44.12% 44.16% +0.04%
====================================================
Files 88 88
Lines 6448 6453 +5
Branches 1348 1349 +1
====================================================
+ Hits 2845 2850 +5
Misses 3555 3555
Partials 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 3-server rings, vault repd instances share hosts and bind to incremental ports (4300, 4301, …). The script had port 4300 hard-coded, so it silently connected to a follower when the leader was on another port, causing "Role not found in vault" for every bucket.