update report adding license information - #35
Merged
mscasso-scanoss merged 7 commits intoJun 5, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds release_date, url_md5, and license through domain types, CSV importer, Qdrant extraction, and protobuf mapping; updates CSV format/docs, language constants, vector key usage, snapshot scripts, .gitignore, and bumps a module dependency. ChangesMetadata Field Expansion
Estimated code review effort 🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/mapper/scan_mapper_impl.go`:
- Around line 112-123: The mapper is incorrectly assigning v.URLMD5 into
scanningv2.HFHResponse_Version.UrlHash which breaks the existing url_hash
contract; change the mapping so scanningv2.HFHResponse_Version.UrlHash is
populated with the original url_hash value (e.g., v.UrlHash or whatever field
carries the original url_hash in the domain model) and expose v.URLMD5 via a new
protobuf field (e.g., UrlMd5) on scanningv2.HFHResponse_Version; update the
append in the function that builds versions to set UrlHash: v.UrlHash and
UrlMd5: v.URLMD5 (and add the new proto field and regenerate types if not
present) while leaving repository/domain persistence of url_hash unchanged.
In `@README.md`:
- Around line 188-191: Update the README note that currently says "Rows with
fewer than 11 fields are skipped" to match the importer behavior in
cmd/import/main.go which now skips rows with fewer than 13 fields; locate the
README's "Rows with fewer than X fields are skipped" sentence and change the
count to 13 so the documentation aligns with the Importer (cmd/import/main.go)
logic and won't mislead users.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 23b54b0f-eef0-45fc-b773-9fd78e417a3a
📒 Files selected for processing (7)
CHANGELOG.mdREADME.mdcmd/import/main.gogo.modinternal/domain/entities/component.gointernal/mapper/scan_mapper_impl.gointernal/repository/scan_repository_qdrant_impl.go
There was a problem hiding this comment.
🧹 Nitpick comments (1)
internal/domain/entities/language.go (1)
83-83: ⚡ Quick winRemove duplicate
extSwiftfrom indexed extensions.
extSwiftappears twice inIndexedLangExtensions, which adds redundant processing and makes the taxonomy inconsistent. Keep it in a single category.Proposed fix
var IndexedLangExtensions = []string{ @@ - "c", "h", "cpp", "cxx", "cc", "hpp", "hxx", "m", "mm", extSwift, + "c", "h", "cpp", "cxx", "cc", "hpp", "hxx", "m", "mm", @@ "dart", "kotlin", extSwift, "gradle",Also applies to: 91-91
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@internal/domain/entities/language.go` at line 83, IndexedLangExtensions contains duplicate entries of the symbol extSwift; remove the redundant extSwift occurrence(s) from the IndexedLangExtensions slice (references to IndexedLangExtensions in internal/domain/entities/language.go) so each extension appears only once—search for extSwift in the IndexedLangExtensions definition and delete the duplicate(s), leaving a single extSwift entry and keeping all other entries unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@internal/domain/entities/language.go`:
- Line 83: IndexedLangExtensions contains duplicate entries of the symbol
extSwift; remove the redundant extSwift occurrence(s) from the
IndexedLangExtensions slice (references to IndexedLangExtensions in
internal/domain/entities/language.go) so each extension appears only once—search
for extSwift in the IndexedLangExtensions definition and delete the
duplicate(s), leaving a single extSwift entry and keeping all other entries
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ac37a89d-7bae-4a8a-9a93-9395177bae6b
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (6)
.gitignorecmd/import/main.gogo.modinternal/domain/entities/language.gointernal/mapper/scan_mapper_impl.gointernal/repository/scan_repository_qdrant_impl.go
✅ Files skipped from review due to trivial changes (1)
- .gitignore
🚧 Files skipped from review as they are similar to previous changes (3)
- internal/mapper/scan_mapper_impl.go
- internal/repository/scan_repository_qdrant_impl.go
- cmd/import/main.go
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/qdrant-restore-snapshots.sh`:
- Around line 56-57: The curl invocation in scripts/qdrant-restore-snapshots.sh
is manually setting the header "-H 'Content-Type:multipart/form-data'" while
also using curl's -F "snapshot=@${file}", which can omit the required multipart
boundary; remove the explicit Content-Type header and let curl set it
automatically so the -F upload uses the correct multipart boundary (locate the
curl command that includes "-H 'Content-Type:multipart/form-data'" and the -F
"snapshot=@${file}" options and delete the -H header).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bc918435-2d61-4827-92a5-90fe5a28a12a
📒 Files selected for processing (4)
README.mdscripts/README.mdscripts/qdrant-generate-snapshots.shscripts/qdrant-restore-snapshots.sh
✅ Files skipped from review due to trivial changes (1)
- scripts/README.md
mscasso-scanoss
deleted the
mscasso/feat/add-urlhash-and-lincese-to-report-SP4189
branch
June 5, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes / Behavior
Documentation
Chores