feat: toggle to hide the ticking menu-bar clock#12
Open
Wegi wants to merge 1 commit into
Open
Conversation
Adds a "Hide timer in menu bar" setting (UserDefaults-backed, same pattern as the idle reminder). While running with the clock hidden the menu bar shows a static record.circle glyph, so tracking is still visible without a ticking clock — e.g. during customer screen shares.
Wegi
force-pushed
the
feat/issue-3-hide-menubar-clock
branch
from
b5d5042 to
e85fb19
Compare
Wegi
force-pushed
the
feat/issue-6-stable-clock
branch
from
c8e8dc7 to
281e2af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
What
New setting "Hide timer in menu bar" so clients in a screen share don't see a ticking clock. While tracking with the clock hidden, the menu bar shows a static
record.circleglyph instead — you still see that tracking is active, just not the time. The popover is unaffected.How
SessionStore.hideMenuBarClockDefaultsKey, following the exactremindWhenIdlepattern.MenuBarLabelreads it via@AppStorageand branches: running+hidden →record.circle, running → ticking clock, idle →timerglyph (unchanged).Tests
The key constant lives in
ConanCore; the branching itself is a trivial SwiftUI view (app target, not unit-testable). Full suite still green (35 tests). Verified by building; visual check: toggle on → glyph while running, toggle off → clock returns.Stack note: stacked on #11 (base branch
feat/issue-6-stable-clock); merge order #10 → #11 → this.