Skip to content

Require cyclebane>=26.9.0 - #243

Closed
SimonHeybrock wants to merge 3 commits into
mainfrom
bump-cyclebane-min-version
Closed

Require cyclebane>=26.9.0#243
SimonHeybrock wants to merge 3 commits into
mainfrom
bump-cyclebane-min-version

Conversation

@SimonHeybrock

Copy link
Copy Markdown
Member

Summary

Test plan

  • None needed beyond CI; ran the full test suite locally against cyclebane 26.9.0, all pass.

cyclebane 26.9.0 fixes a reference-cycle bug (scipp/cyclebane#33) where
networkx report views cached on graphs kept them alive until the cyclic
garbage collector ran, causing unbounded memory growth in long-running
pipelines that repeatedly update data (see scipp/esslivedata#1264,
scipp/esslivedata#1266).
cyclebane 26.9.0 requires Python >=3.12, so sciline's minimum must
follow suit. Updated via `copier update` (min_python -> 3.12) plus the
docs workflow, which can now use the min-version file directly instead
of hard-coding 3.12 to work around a 3.11 typing issue.
Dropping the Python 3.11 minimum flips on ruff's UP046/UP047, which
want generic defs/classes rewritten to PEP 695 type-parameter syntax.
sciline's own generics don't support that syntax yet (#233,
#235), so ignore these rules until that's addressed.
@SimonHeybrock

Copy link
Copy Markdown
Member Author

Closing — bumping the cyclebane minimum requires dropping Python 3.11 support, which in turn surfaces pre-existing typing incompatibilities (#233) that block CI. Opening a tracking issue with details instead of working around them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant