Require cyclebane>=26.9.0 - #243
Closed
SimonHeybrock wants to merge 3 commits into
Closed
Conversation
cyclebane 26.9.0 fixes a reference-cycle bug (scipp/cyclebane#33) where networkx report views cached on graphs kept them alive until the cyclic garbage collector ran, causing unbounded memory growth in long-running pipelines that repeatedly update data (see scipp/esslivedata#1264, scipp/esslivedata#1266).
cyclebane 26.9.0 requires Python >=3.12, so sciline's minimum must follow suit. Updated via `copier update` (min_python -> 3.12) plus the docs workflow, which can now use the min-version file directly instead of hard-coding 3.12 to work around a 3.11 typing issue.
Member
Author
|
Closing — bumping the cyclebane minimum requires dropping Python 3.11 support, which in turn surfaces pre-existing typing incompatibilities (#233) that block CI. Opening a tracking issue with details instead of working around them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
G.edges,G.out_degree) kept the graph alive until the cyclic garbage collector ran.Test plan