Add compute_single_crystal_norm - #726
Open
jl-wynen wants to merge 3 commits into
Open
Conversation
jl-wynen
force-pushed
the
add-algo-package
branch
from
August 27, 2026 14:26
93440d4 to
60ae66f
Compare
jl-wynen
commented
Aug 27, 2026
| uses: mamba-org/setup-micromamba@v3.2.1 | ||
| with: | ||
| micromamba-version: 2.0.4-0 | ||
| micromamba-version: 2.9.0-0 |
Member
Author
There was a problem hiding this comment.
We need a recent version for support for the stable abi3.
nvaytet
reviewed
Sep 9, 2026
| incident_energy=incident_energy, | ||
| n_threads=n_threads, | ||
| block_size=block_size, | ||
| ) |
Member
There was a problem hiding this comment.
Do we need a small unit tests to check that it at least runs?
Member
Author
There was a problem hiding this comment.
Definitely! I just forgot to commit it 🤦
jl-wynen
force-pushed
the
add-algo-package
branch
from
September 9, 2026 13:09
025fa86 to
71ef745
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a wrapper for the
compute_single_crystal_normfunction fromscippneutron_algorithms.The function needs a lot more documentation but I want to wait until we know more precisely how we will use it. Its interface will likely change, in particular around how trajectories are defined. But publishing this allows us and the CIS's to use and test the function.