Unpin scipy version (and mpmath version) - #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unpins SciPy, which was set at the oldest version prior to SciPy depending on
xsfin order to remain an independent reference. I was planning to remove SciPy as a dependency entirely, but I now think that isn't actually desirable; it's still useful for generating reference tolerances and checking consistency with thempmathimplementations. I do plan to stop using it as a fallback though, and think we can fill in the remaining gaps in reference implementations with the free for open source use Wolfram engine. This PR should unblock scipy/xsf#175. I've also unpinned thempmathversion. I think I had planned to manually check things out before eachmpmathupdate to guard against regressions, but I don't have bandwidth for that.