[ISSUE 534]: Deprecate conda environment.yml / move to pip#552
[ISSUE 534]: Deprecate conda environment.yml / move to pip#552HundredBillion wants to merge 12 commits into
Conversation
|
Thanks for the PR, @HundredBillion! This doesn't resolve #534 because installing still uses conda .yml files. I'll give comments inline presently |
|
@sdatkinson - I noticed your PR to change the url for installing Pytorch. I updated this PR in case you still want to use update the docs to install via |
sdatkinson
left a comment
There was a problem hiding this comment.
I'm sorry, but this still isn't what I want. There are yml files still in the repo. Moving to pip should see them gone.
Got it — I misunderstood the issue. I treated it as “use pip inside the conda env files,” but what you want is to remove the conda env approach entirely. I’ll update the PR to delete the environment .yml files and switch the installation docs to a pip/venv-based flow. |
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s installation guidance to move away from conda-based environment setup and toward pip/venv-based installation, addressing Issue #534 about PyTorch no longer being available via conda.
Changes:
- Removed conda environment definitions for CPU (Apple) and GPU setups.
- Rewrote the installation docs to use Python +
venv+python -m pip. - Updated local development setup instructions to use editable installs and manual dev tooling installation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| environments/environment_gpu.yml | Removes the GPU conda environment definition. |
| environments/environment_cpu_apple.yml | Removes the Apple/CPU conda environment definition. |
| docs/source/installation.rst | Updates installation and development instructions to use venv + pip and points users to PyTorch’s install selector. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @HundredBillion — random passer-by here, also interested in seeing #534 land. A few suggestions if useful, take or leave:
Tried all three locally on top of |
Moves black, flake8, and pre-commit into a declared [dev] extra so the dev environment can be set up with a single pip install -e ".[dev,test]".
Drops the non-GPU "pip install torch" step since torch is already pulled in transitively by "pip install neural-amp-modeler". Updates the dev install to a single "pip install -e .[dev,test]" command.
Drops the --conda-env CLI flag, conda_env parameter, and conda run command branch — none of which were used by the pytest path.
|
@rhaist - Thanks for your review. I applied all 3 changes you suggested because I think they are all in scope for this PR. |
This PR resolves Issue 534.
Since PyTorch is no longer shipping conda packages, this PR removes the conda environment files and switches the installation docs to a standard Python pip/venv-based setup.
For GPU installs, PyTorch's commands depend on the user's OS and CUDA version, so the docs point to the official PyTorch install page rather than hardcoding a command:
https://pytorch.org/get-started/locally/
For CPU-only and Apple Silicon users,
torchis already declared in[project.dependencies], so it is installed automatically bypip install neural-amp-modeler— no separate PyTorch install step is needed.Summary of changes
environments/environment_cpu_apple.ymlandenvironments/environment_gpu.ymldocs/source/installation.rstto use a 4-step pip/venv install flow with OS-specific venv activation commands (macOS/Linux, Windows cmd.exe, Windows PowerShell)[dev]optional-dependencies group topyproject.toml(black,flake8,pre-commit) so the full dev environment installs with a single command:pip install -e ".[dev,test]"pip install torchstep from the docs, sincetorchis pulled in transitively bypip install neural-amp-modelertests/test_graceful_shutdown.py(--conda-envCLI flag and related branching logic that was never exercised by the pytest path)