[FEATURE] Add epoch-level progress bar to full trainer#658
Open
eliasgomes wants to merge 1 commit into
Open
Conversation
def46da to
9fc1dfc
Compare
Add a second Rich progress bar showing overall epoch progress below the existing per-batch bar. Shows elapsed time, remaining time estimate, and epoch count using Lightning's N/max-1 convention. - Extend RichProgressBar with _EpochProgressBar callback - Add _EpochCountColumn for epoch count display - Use transient Rich Progress for clean terminal output on both normal completion and Ctrl+C interruption - Remove v_num from displayed metrics - Add unit tests for both new classes
9fc1dfc to
47c9776
Compare
Owner
|
This is a cool idea. I'd like to support this--but optionally. I could've sworn I'd implemented the ability to add callbacks via the configuration (i.e. the learning.json). So you could make "callbacks": [
{
"name": "eliasgomes_package.nam.EpochProgressBar",
"args": [],
"kwargs": {}
}
](probably under the And it'd initialize and append this (and maybe others) using If you want to PR me that then you can use your progress bar and I can put in other things I like 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When training with
nam-full, only a per-batch progress bar is shown, making it hard to tell overall training progress across epochs. This adds a second Rich progress bar below the existing one that tracks epoch completion with elapsed and remaining time estimates.Before
After
Changes
_EpochProgressBarcallback extendingRichProgressBarwith a separate epoch-level progress bar_EpochCountColumnfor epoch count display using Lightning'sN/max-1conventionv_numfrom displayed metrics (always 0 for single-logger setups)Epoch Non the per-batch bar (total is redundant with the epoch bar)