Log per-submodel MRSTFT metrics during packed validation#669
Merged
sdatkinson merged 1 commit intoMay 23, 2026
Merged
Conversation
Packed training already computed MRSTFT per submodel but only logged
the summed aggregate. Log each loss key as {key}_packed_{i} so MRSTFT
matches ESR/MSE visibility in TensorBoard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MRSTFT_packed_0,MRSTFT_packed_1), not only ESR/MSEMRSTFT(sum across submodels) is unchangedTest plan
pytest tests/test_nam/test_train/test_lightning_module.py::test_packed_lightning_validation_logs_per_submodel_and_aggregatepytest tests/test_nam/test_train/test_lightning_module.py::test_packed_lightning_validation_logs_mrstft_per_submodel