Svelte Markdown example (Remark, Rehype, Svelte Components) - #587
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Vite 6 is recommended |
|
@git-no Can you add the |
|
|
@sdorra pnpm-lockfile is now integrated. My build locally failed with samples-arktype:build: sh: Zeile 1: content-collections: Kommando nicht gefunden.
samples-xml:build: sh: Zeile 1: content-collections: Kommando nicht gefunden.
samples-cli:build: sh: Zeile 1: content-collections: Kommando nicht gefunden.
samples-arktype:build: ELIFECYCLE Command failed.
samples-xml:build: ELIFECYCLE Command failed.
samples-cli:build: ELIFECYCLE Command failed.
samples-valibot:build:
samples-valibot:build: > samples-valibot@0.1.0 build /Users/lukas/code/labs/svelte-content-collections/samples/valibot
samples-valibot:build: > content-collections build
samples-valibot:build:
@content-collections/remix-vite:build: cache miss, executing 2d16bb4e9a8811e9
@content-collections/vinxi:build: cache miss, executing 29946ae7386e1a66
@content-collections/remix-vite:build:
samples-valibot:build: sh: Zeile 1: content-collections: Kommando nicht gefunden.
samples-valibot:build: ELIFECYCLE Command failed.
@content-collections/vinxi:build:
samples-xml:build: ERROR: command finished with error: command (/Users/lukas/code/labs/svelte-content-collections/samples/xml) /Users/lukas/Library/pnpm/.tools/pnpm/8.15.8/bin/pnpm run build exited (1)
@content-collections/vinxi:build:
@content-collections/remix-vite:build:
samples-xml#build: command (/Users/lukas/code/labs/svelte-content-collections/samples/xml)
Tasks: 8 successful, 15 total
Cached: 0 cached, 15 total
Time: 5.133s
Failed: samples-xml#build
ERROR run failed: command exited (1)
ELIFECYCLE Command failed with exit code 1. |
|
@sdorra Are there any plans to update Vite to version 6 in the repository? |
No concrete plans yet. Once I finish the work on #471 and then #494, I will make the long-overdue upgrades to Next and Vite. For Vite, we need to ensure compatibility with v5 and v6.
The problem is that these tests use the # install dependencies
pnpm install
# build the cli
pnpm build --filter=@content-collections/cli
# ensure the cli is linked
pnpm install
# build all packages
pnpm build
# run the tests
pnpm testThis should probably be in the README 🤔 |
|
The ci process still ends with the following error: ERR_PNPM_OUTDATED_LOCKFILE Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with samples/svelte-kit/package.jsonHave you done a |
| "vite": "^5.4.6" | ||
| "@content-collections/core": "workspace:*", | ||
| "@content-collections/markdown": "workspace:*", | ||
| "@content-collections/vite": "workspace:*", |
There was a problem hiding this comment.
Please keep the fixed versions. They have to be fixed because the samples must be openable in StackBlitz, and StackBlitz only looks at the folder of the sample, not the whole repo.
There was a problem hiding this comment.
no problem, I did rewrite these entries.
|
@sdorra "Please keep the fixed versions. " I do not get it? What do you like to have in package.json, my version or the previous version with Vite 5? Just |
|
You have changed the version of the Please retain the old versions of the I am currently not at home and will return on Sunday. I will review the failing tests then. |
|
I've added some styling and sample posts. I will update the tests tomorrow, and then we can merge the PR. |
|
@git-no i've updated the sample to match the look and feel of the other (newer) samples. The build and the tests are working now. But i've noticed that every svelte component i've used inside markdown is wrapped in a |
|
I will check next week. |
|
@sdorra
Do you have an example / repository? |
Yeah, this pull request. Each MD file uses a different Svelte component and all of them a wrapped with a p tag. |
1e28b7f to
50aead7
Compare
eb76dde to
759321d
Compare
No description provided.