Make sel4 "state" feature opt-out-able across workspace#335
Open
Make sel4 "state" feature opt-out-able across workspace#335
Conversation
Add `default-features = false` to all in-workspace `sel4` dependencies so the `state` feature (thread-local IPC buffer) is not forced on every crate by feature unification. Runtime crates that require state (`sel4-root-task`, `sel4-microkit`, `sel4-microkit-base`, `sel4-simple-task-runtime`, `sel4-root-task-with-std`, `spawn-task-child`, `spawn-thread`) explicitly request `features = ["state"]` on their `sel4` dependency. All other crates get only `default-features = false`. Validated by: `make run-fast-tests` (all tests pass on all architectures) Signed-off-by: Mark Old <mold@redhat.com>
dlom
force-pushed
the
mold/make-state-not-default-everywhere
branch
from
43f9243 to
f267b1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
default-features = falseto all in-workspacesel4dependencies so thestatefeature (thread-local IPC buffer) is not forced on every crate by feature unification.Runtime crates that require state (
sel4-root-task,sel4-microkit,sel4-microkit-base,sel4-simple-task-runtime,sel4-root-task-with-std,spawn-task-child,spawn-thread) explicitly requestfeatures = ["state"]on theirsel4dependency. All other crates get onlydefault-features = false.Validated by:
make run-fast-tests(all tests pass on all architectures)