refactor: share invalid header handling#221
Merged
seanmonstar merged 1 commit intoJun 30, 2026
Merged
Conversation
Contributor
Author
|
Benchmark differences look like only noise, but you should take a look. You'll want to ignore the indentation change in the diff. |
handle_invalid_char! duplicates the invalid char recovery loop at all macro expansions. Share it with a labeled block. This reduces code size by about 3KiB.
thaliaarchi
force-pushed
the
dedupe-invalid-header
branch
from
d27d5e7 to
fb28959
Compare
Contributor
Author
|
Spurious CI failure. Can you rerun it? |
seanmonstar
approved these changes
Jun 30, 2026
seanmonstar
left a comment
seanmonstar
left a comment
Owner
There was a problem hiding this comment.
Nice! I love it, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_invalid_char!duplicates the invalid char recovery loop at all macro expansions. Share it with a labeled block. This reduces code size by about 3KiB.