Skip to content

Fix deploy failure after Next.js 16.3.0 upgrade - #532

Merged
seanprashad merged 1 commit into
mainfrom
fix/sw-test-trigger-type
Aug 4, 2026
Merged

Fix deploy failure after Next.js 16.3.0 upgrade#532
seanprashad merged 1 commit into
mainfrom
fix/sw-test-trigger-type

Conversation

@seanprashad

@seanprashad seanprashad commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Widens the trigger helper parameter in sw.test.ts from Record<string, unknown> to unknown
  • Fixes the Deploy to GitHub Pages failure introduced by Next.js 16.3.0 (Bump sharp and next #530), which now type-checks test files during next build

Context

Next.js 16.3.0 surfaced a latent type error: FetchEvent is not assignable to Record<string, unknown> because it lacks an index signature. The test logic was always correct; only the helper typing was wrong.

Next.js 16.3.0 type-checks test files during build, exposing a latent
mismatch where FetchEvent was passed to a Record<string, unknown> param.

Co-authored-by: Cursor <cursoragent@cursor.com>
@seanprashad
seanprashad marked this pull request as ready for review August 4, 2026 11:51
@seanprashad
seanprashad merged commit 802ae7e into main Aug 4, 2026
3 checks passed
@seanprashad
seanprashad deleted the fix/sw-test-trigger-type branch August 4, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant