cephadm_install: move distro vars into the role - #977
Closed
insatomcat wants to merge 1 commit into
Closed
Conversation
The role's per-distro variables (uid/gid, logrotate path) were only
ever consumed by cephadm_install itself, so loading them from
/vars/{Distro}_cephadm_install.yml at playbook level added no value
over the standard in-role vars/ convention already used by roles like
snmp and timemaster. Move them to roles/cephadm_install/vars/{Distro}.yml
and include_vars from within the role's own tasks/main.yml, dropping
the now-unneeded include_vars step from cluster_setup_cephadm.yaml.
Signed-off-by: Florent Carli <florent.carli@rte-france.com>
Member
Author
|
PR merged into #983 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The role's per-distro variables (uid/gid, logrotate path) were only ever consumed by cephadm_install itself, so loading them from /vars/{Distro}_cephadm_install.yml at playbook level added no value over the standard in-role vars/ convention already used by roles like snmp and timemaster.
Move them to roles/cephadm_install/vars/{Distro}.yml and include_vars from within the role's own tasks/main.yml, dropping the now-unneeded include_vars step from cluster_setup_cephadm.yaml.