cephadm_install: derive the Ceph release name from the release version - #982
Closed
insatomcat wants to merge 1 commit into
Closed
cephadm_install: derive the Ceph release name from the release version#982insatomcat wants to merge 1 commit into
insatomcat wants to merge 1 commit into
Conversation
"cephadm add-repo" takes a release name while the cephadm download URL takes a version number. Both were pinned separately, so bumping cephadm_install_release alone silently left the repo on the previous release, mixing a binary from one Ceph version with packages from another. Derive the name from the major version through a lookup table, and assert before add-repo that a name is known, so an unlisted version fails with an explicit message instead of installing the wrong repo. Setting cephadm_install_release_name explicitly still overrides the derivation. Signed-off-by: Florent Carli <florent.carli@rte-france.com>
Member
Author
|
PR merged into #983 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"cephadm add-repo" takes a release name while the cephadm download URL takes a version number. Both were pinned separately, so bumping cephadm_install_release alone silently left the repo on the previous release, mixing a binary from one Ceph version with packages from another.
Derive the name from the major version through a lookup table, and assert before add-repo that a name is known, so an unlisted version fails with an explicit message instead of installing the wrong repo. Setting cephadm_install_release_name explicitly still overrides the derivation.