workflows/ci-debian.yml: pin each matrix job to its own runner label - #990
Open
insatomcat wants to merge 1 commit into
Open
workflows/ci-debian.yml: pin each matrix job to its own runner label#990insatomcat wants to merge 1 commit into
insatomcat wants to merge 1 commit into
Conversation
The concurrency group added to serialize the standalone and cluster jobs on the shared test hardware had an unwanted side effect: GitHub only keeps one pending job per concurrency group, and a newly queued job evicts the one already waiting, which is then reported as cancelled. With cancel-in-progress set to false the running job is protected, but the pending one is not, and this is not configurable. Three overlapping runs were enough to trigger it. In run 30283299611 the cluster job was queued at 16:14:32 behind a job from an older run, then cancelled at 16:15:07 when another run reached the same group. The two Debian runners now carry a dedicated label each, so the runner queue itself serializes the jobs per hardware: jobs pile up instead of being cancelled, and a job can no longer land on the machine dedicated to the other topology. The concurrency group is therefore no longer needed. Signed-off-by: Florent Carli <florent.carli@rte-france.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concurrency group added to serialize the standalone and cluster jobs on the shared test hardware had an unwanted side effect: GitHub only keeps one pending job per concurrency group, and a newly queued job evicts the one already waiting, which is then reported as cancelled. With cancel-in-progress set to false the running job is protected, but the pending one is not, and this is not configurable.
Three overlapping runs were enough to trigger it. In run 30283299611 the cluster job was queued at 16:14:32 behind a job from an older run, then cancelled at 16:15:07 when another run reached the same group.
The two Debian runners now carry a dedicated label each, so the runner queue itself serializes the jobs per hardware: jobs pile up instead of being cancelled, and a job can no longer land on the machine dedicated to the other topology. The concurrency group is therefore no longer needed.