fix(scaffolder): fix template card type in entity-scaffolder-content#70
Open
roope-t wants to merge 1 commit into
Open
fix(scaffolder): fix template card type in entity-scaffolder-content#70roope-t wants to merge 1 commit into
roope-t wants to merge 1 commit into
Conversation
Contributor
Author
|
Hey @zhammer, this fixes a small issue that I noticed now when starting to use the plugin. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the typing of the TemplateCard override in EntityScaffolderContent so that consumers must provide a component compatible with the TemplateGroups API from @backstage/plugin-scaffolder-react/alpha.
Changes:
- Import
TemplateCardfrom@backstage/plugin-scaffolder-react/alpha. - Update
EntityScaffolderContentProps.components.TemplateCardto usetypeof TemplateCardinstead of a customReact.ComponentTypesignature.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the type of TemplateCard prop in EntityScaffolderContent component.