feat(slack): prefer enterprise Slack user ID in processor#85
Merged
Conversation
Add coverage for using `enterprise_user.id` when available and falling back to the top-level Slack user ID otherwise.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Slack catalog backend processor to prefer Slack Enterprise Grid user IDs (when available) while keeping the existing behavior as a fallback, and adds tests to cover both paths.
Changes:
- Prefer
slackUser.enterprise_user.idoverslackUser.idwhen writing theslack.com/user_idannotation. - Add unit tests to verify enterprise ID preference and fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/slack-catalog-backend/src/SlackUserProcessor.ts | Prefer enterprise Slack user ID (fallback to top-level ID) when annotating Backstage user entities. |
| plugins/slack-catalog-backend/src/SlackUserProcessor.test.ts | Add test coverage for enterprise ID preference and fallback behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
colinodell
approved these changes
Apr 14, 2026
colinodell
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add coverage for using
enterprise_user.idwhen available and falling back to the top-level Slack user ID otherwise.