Skip to content

MNT: bump to sklearn 1.9 and adapt to it#593

Open
cakedev0 wants to merge 10 commits into
sebp:mainfrom
cakedev0:mnt/bump/sklearn19
Open

MNT: bump to sklearn 1.9 and adapt to it#593
cakedev0 wants to merge 10 commits into
sebp:mainfrom
cakedev0:mnt/bump/sklearn19

Conversation

@cakedev0
Copy link
Copy Markdown
Contributor

@cakedev0 cakedev0 commented May 29, 2026

Checklist

  • pytest passes locally, with sklearn 1.9.0rc1 installed manually.
  • code is well formatted
  • documentation renders correctly
  • CI passes

What does this implement/fix? Explain your changes

Bump scikit-learn to 1.9.0, and update the code to adapt to some changes in scikit-learn:

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 29, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 5 complexity · 0 duplication

Metric Results
Complexity 5
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

"output_type": "stream",
"text": [
"0.756\n"
"0.765\n"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the score improved! 🎉

But according to Codex:

I’d frame this as a numerically fragile tie exposed by sklearn tree splitter changes, not a meaningful model improvement and not directly the friedman_mse GB bugfix.

The difference only happens at iteration 88 of the GB due to an improvement delta of 3.6e-15 between two options. This is pure chance.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.46%. Comparing base (0361ab9) to head (ba407d7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          38       38           
  Lines        3715     3723    +8     
  Branches      481      484    +3     
=======================================
+ Hits         3658     3666    +8     
  Misses         27       27           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cakedev0 cakedev0 marked this pull request as ready for review June 3, 2026 07:13
@cakedev0 cakedev0 requested a review from sebp as a code owner June 3, 2026 07:13
@cakedev0 cakedev0 changed the title [do not merge] MNT: bump to sklearn 1.9 and adapt to it MNT: bump to sklearn 1.9 and adapt to it Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant