MNT: bump to sklearn 1.9 and adapt to it#593
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
| "output_type": "stream", | ||
| "text": [ | ||
| "0.756\n" | ||
| "0.765\n" |
There was a problem hiding this comment.
It seems the score improved! 🎉
But according to Codex:
I’d frame this as a numerically fragile tie exposed by sklearn tree splitter changes, not a meaningful model improvement and not directly the friedman_mse GB bugfix.
The difference only happens at iteration 88 of the GB due to an improvement delta of 3.6e-15 between two options. This is pure chance.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 38 38
Lines 3715 3723 +8
Branches 481 484 +3
=======================================
+ Hits 3658 3666 +8
Misses 27 27
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Checklist
What does this implement/fix? Explain your changes
Bump scikit-learn to 1.9.0, and update the code to adapt to some changes in scikit-learn:
GradientBoostingSurvivalAnalysis,see PR MNT: trees/forests/GBT: deprecate"friedman_mse"criterion scikit-learn/scikit-learn#32708LogrankCriterion, this is now handled entirely outside of criterion logic in scikit-learn. See PR FEA Add support for missing values in tree estimators withcriterion="absolute_error"by greatly simplifying the logic scikit-learn/scikit-learn#32119DTYPEfromsklearn.tree._tree, usenp.float32directly instead (which reflects what was done in scikit-learn)_check_sample_weightto align on scikit-learnmax_samplesvalidation accordinglyCalibratedClassifierCVaroundSVCbecauseSVC(probability=True)is now deprecated