Draft
Conversation
Cleanup of the function, since these parts should remain unchanged.
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks avatar visual complexity (ARC) updates toward a cached/partial-recalculation model, aiming to avoid expensive full recomputation on every attachment/texture change.
Changes:
- Adds per-attachment/body/control-avatar complexity caching with dirty-marking APIs on
LLVOAvatar. - Switches various call sites (e.g., attach/detach, volume complexity updates) to mark components dirty instead of forcing immediate full updates.
- Refactors complexity reporting into a helper and preserves the previous algorithm as a “legacy” implementation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
indra/newview/llvovolume.cpp |
Updates volume-triggered complexity updates to mark the owning avatar’s attachment complexity dirty. |
indra/newview/llvoavatar.h |
Introduces complexity cache structures, dirty sets, and new complexity update/dirty-mark methods; expands accountRenderComplexityForObject parameters. |
indra/newview/llvoavatar.cpp |
Implements cached complexity computation (full vs partial), adds cache maintenance helpers, updates attach/detach to mark dirty, and extracts reporting logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/5569_complexity_rework
branch
from
3cac2f3 to
6b02f0d
Compare
akleshchev
force-pushed
the
andreyk/5569_complexity_rework
branch
from
6b02f0d to
fbd0686
Compare
akleshchev
force-pushed
the
andreyk/5569_complexity_rework
branch
from
ce92fa2 to
787b972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP. Draft of logic for partial complexity updates.
It is a mess and not yet tested. It's in 2026.02 because I started work there, will move to develop later.