Bring in an updated Dullahan autobuild package containing an updated version of CEF 146#5584
Open
callumlinden wants to merge 1 commit intodevelopfrom
Open
Bring in an updated Dullahan autobuild package containing an updated version of CEF 146#5584callumlinden wants to merge 1 commit intodevelopfrom
callumlinden wants to merge 1 commit intodevelopfrom
Conversation
…rsion of CEF v146. No changes to Dullahan or Viewer C++ code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings in a new version of the Dullahan autobuild package that was built was against CEF version 146.
This change is for Windows and macOS only. Linux version to follow when we are able to create a compatible v146 version of CEF.
No changes were required in Dullahan or Viewer C++ code - merely updated in Dullahan autobuild.xml to point to the new C++ binaries and in the Viewer autobuild.xml to point to the updated Dullahan.
For QA/testing, it's been 7 months since the version of CEF used in the canonical Viewer (v139) was released so there will be a very large number of changes in CEF itself.
I did a simple smoke test and confirmed that web pages appear to render as before, links work, keyboard works etc. but if there are issues to resolve, it will be in the more esoteric areas of integration - SLURL support, multiple windows, cookie management etc. I don't know if this warrants a full browser integration regression test - perhaps we wait for feedback in the alpha phase before making that call.