Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying frameworks with
|
| Latest commit: |
136758b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d9c9b858.frameworks-573.pages.dev |
| Branch Preview URL: | https://chore-sitemap.frameworks-573.pages.dev |
smagdali
reviewed
Feb 10, 2026
Collaborator
smagdali
left a comment
There was a problem hiding this comment.
One comment, the rest looks good. I wouldn't let my comment be a blocker if you're squeezed for time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a sitemap.xml generator that is processes by CF at build time.
At the moment, it is only a simple sitemap with all the links, as we are in a urgent need of this file, and there will be no
<lastmod>tag as it's a tricky thing to add for various reasons (CI/CD environments do not have access to the full git history if not forced to + vocs already process the "last modified" date but they display it at runtime and this script runs postbuild so there is no way to read that) and will need extra work and time to understand how to safely get them.Example:
Closes #359
Frameworks PR Checklist
Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:
vocs.config.tsadding thedev: trueparameter