Open
Conversation
Unit is turned back to input unit if conversion does not take place. Foreign keys are added and converted later.
henhuy
reviewed
Dec 9, 2024
Collaborator
henhuy
left a comment
henhuy
left a comment
There was a problem hiding this comment.
Apart from one part which I don't quite unserstand, I think this is a good solution.
data_adapter/preprocessing.py
Outdated
Comment on lines
271
to
273
| except TypeError: # occurs for foreign keys | ||
| # rewrite unit as conversion did not take place | ||
| df_units[field["name"]] = field["unit"] |
Collaborator
There was a problem hiding this comment.
I don't understand why this is needed? or why a TypeError is thrown.
In line 256 i see the same line, maybe check if conversion can be done should be moved upwards?
Author
There was a problem hiding this comment.
Good point. I moved the check upwards, in line with the other checks.
TypeError is thrown because string (foreign key) cannot be multiplied by float.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.