fix(server): accept Windows backslash paths - #3
Merged
seekskyworld merged 3 commits intoAug 27, 2026
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
What changed
Fix a Windows-only bug that caused the CreatPPT web workspace to return
403 Forbiddenwhen opening the root URL.In
src/server/server.ts,serveClient()previously checked whether theresolved client path started with
${root}/. On Windows,path.resolve()returns paths using backslashes, so the prefix check failed even for valid
paths such as
index.html.The check now uses
path.relative()together with the platform separator,which works on both Windows and POSIX systems while preserving path traversal
protection.
Fixes #2
Validation
npm run build/returns HTTP 200 withtext/html/api/healthreturns HTTP 200/api/deckreturns HTTP 200npm run checknpm run audit:releasenpm run package:smokeRelease and safety