Skip to content

Backport release/v6.4: fix to ProposalPOLMessage poisoning (CON-222)#3139

Merged
masih merged 3 commits intorelease/v6.4from
backport-3129-to-release/v6.4
Mar 31, 2026
Merged

Backport release/v6.4: fix to ProposalPOLMessage poisoning (CON-222)#3139
masih merged 3 commits intorelease/v6.4from
backport-3129-to-release/v6.4

Conversation

@seidroid
Copy link
Copy Markdown

@seidroid seidroid bot commented Mar 30, 2026

Backport of #3129 to release/v6.4.

The bug was about panic after setting vote at out of range index. Added
a test. Additionally I have also made getters return bool to indicate if
get succeeded.

(cherry picked from commit d201e89)
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 31, 2026, 8:29 AM

@github-actions
Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 30, 2026, 3:41 PM

@pompon0 pompon0 requested a review from sei-will March 30, 2026 17:01
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 59.22330% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.44%. Comparing base (20c6b86) to head (824ca93).
⚠️ Report is 1 commits behind head on release/v6.4.

Files with missing lines Patch % Lines
sei-tendermint/internal/consensus/state.go 33.33% 4 Missing and 4 partials ⚠️
sei-tendermint/types/vote_set.go 56.25% 5 Missing and 2 partials ⚠️
sei-tendermint/types/block.go 53.84% 3 Missing and 3 partials ⚠️
...tendermint/internal/consensus/types/round_state.go 33.33% 2 Missing and 2 partials ⚠️
sei-tendermint/types/validation.go 66.66% 2 Missing and 2 partials ⚠️
sei-tendermint/internal/evidence/verify.go 40.00% 1 Missing and 2 partials ⚠️
sei-tendermint/test/e2e/runner/evidence.go 0.00% 3 Missing ⚠️
sei-tendermint/types/evidence.go 57.14% 1 Missing and 2 partials ⚠️
sei-tendermint/types/part_set.go 33.33% 1 Missing and 1 partial ⚠️
sei-tendermint/node/setup.go 66.66% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v6.4    #3139      +/-   ##
================================================
+ Coverage         58.43%   58.44%   +0.01%     
================================================
  Files              2088     2088              
  Lines            172060   172087      +27     
================================================
+ Hits             100537   100570      +33     
+ Misses            62569    62556      -13     
- Partials           8954     8961       +7     
Flag Coverage Δ
sei-chain-pr 64.03% <59.22%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-ibc-go/testing/chain.go 93.98% <100.00%> (ø)
sei-tendermint/internal/consensus/msgs.go 81.60% <ø> (ø)
sei-tendermint/internal/consensus/peer_state.go 88.33% <100.00%> (+3.84%) ⬆️
sei-tendermint/internal/consensus/reactor.go 71.12% <100.00%> (+1.63%) ⬆️
...rmint/internal/consensus/types/peer_round_state.go 100.00% <ø> (ø)
sei-tendermint/internal/rpc/core/status.go 81.01% <100.00%> (ø)
sei-tendermint/types/proposal.go 85.71% <100.00%> (ø)
sei-tendermint/types/validator_set.go 93.10% <100.00%> (ø)
sei-tendermint/node/setup.go 67.03% <66.66%> (ø)
sei-wasmd/x/wasm/ibctesting/chain.go 68.22% <0.00%> (-0.32%) ⬇️
... and 9 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih enabled auto-merge (squash) March 31, 2026 08:31
@masih masih merged commit 8c5c58a into release/v6.4 Mar 31, 2026
38 checks passed
@masih masih deleted the backport-3129-to-release/v6.4 branch March 31, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants