Skip to content

Build the Ethereum chain config once per fee check#3165

Merged
amir-deris merged 3 commits intomainfrom
amir/plt-233-build-ethereum-chain-config-once-per-fee-check
Apr 2, 2026
Merged

Build the Ethereum chain config once per fee check#3165
amir-deris merged 3 commits intomainfrom
amir/plt-233-build-ethereum-chain-config-once-per-fee-check

Conversation

@amir-deris
Copy link
Copy Markdown
Contributor

There are areas we build the ChainConfig twice and it can simply be built once and reused to improve performance.

@amir-deris amir-deris self-assigned this Apr 1, 2026
@amir-deris amir-deris changed the title plt-233 reused config in evm_checktx.go and fee.go Build the Ethereum chain config once per fee check Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 2, 2026, 3:52 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.56%. Comparing base (fedf0f8) to head (7bba778).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/ante/evm_checktx.go 66.66% 1 Missing ⚠️
x/evm/ante/fee.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3165      +/-   ##
==========================================
- Coverage   58.62%   58.56%   -0.07%     
==========================================
  Files        2055     2099      +44     
  Lines      168301   173362    +5061     
==========================================
+ Hits        98670   101531    +2861     
- Misses      60861    62687    +1826     
- Partials     8770     9144     +374     
Flag Coverage Δ
sei-chain-pr 49.63% <66.66%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/ante/evm_checktx.go 35.37% <66.66%> (+0.16%) ⬆️
x/evm/ante/fee.go 73.01% <66.66%> (+1.14%) ⬆️

... and 115 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amir-deris amir-deris requested a review from bdchatham April 2, 2026 16:13
Copy link
Copy Markdown

@bdchatham bdchatham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amir-deris amir-deris added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit ac5ad8d Apr 2, 2026
39 checks passed
@amir-deris amir-deris deleted the amir/plt-233-build-ethereum-chain-config-once-per-fee-check branch April 2, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants