Conversation
🦋 Changeset detectedLatest commit: dd88bdc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sei-will
approved these changes
Apr 2, 2026
codebycarson
approved these changes
Apr 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 79.69% 79.75% +0.06%
==========================================
Files 83 83
Lines 1305 1309 +4
Branches 158 160 +2
==========================================
+ Hits 1040 1044 +4
Misses 265 265 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(mcp-server): enforce session binding and response isolation in HTTP SSE transport
The HTTP SSE transport had two related failures that allowed cross-client request injection and response misrouting when multiple clients were connected simultaneously:
The POST handler always routed to
Array.from(this.connections.values())[0], ignoring thesessionIdquery parameter entirely. A request with a fabricated or absent session ID was accepted and executed within another client's live session.Session IDs were generated with
Date.now()instead oftransport.sessionId(the SDK-issued identifier), so the connections map key was never meaningfully tied to the transport that produced it.Changes:
req.query.sessionIdand rejects missing values (400) or unknown session IDs (404) before the request reaches any transporttransport.sessionId(the MCP SDK's own identifier) rather than a local timestamp