Correct load_class bugs in tabsurvey models#1
Open
joelromanky wants to merge 6 commits into
Open
Conversation
…ld `pymoo` version.
Lightweight version on Python 3.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the
load_classfunction intorch_models.pyto ensure that model scalers are correctly re-initialized during loading. It now automatically loadsScalerDatafrom ascaler.jsonfile if one is present, ensuring the model's internal dimensions align with the training state.Changes:
load_classintabularbench/models/torch_models.pyto check for and loadscaler.jsonif a scaler is not explicitly provided inkwargs.TabScaleris properly fitted with the loadedScalerDatabefore model initialization, preventingsize mismatcherrors in thestate_dictduringload_state_dict().scaler.jsonis missing, ensuring configuration integrity.tabularbench/models/tabsurveyfolder to ensure consistency with the new loading flow.Impact:
RuntimeError: Error(s) in loading state_dict(size mismatches) that occurred when loading pre-trained models.