fix(logging): use write_all for atomic JSONL line writes (#108)#59
Open
chris-sevorix wants to merge 1 commit into
Open
fix(logging): use write_all for atomic JSONL line writes (#108)#59chris-sevorix wants to merge 1 commit into
chris-sevorix wants to merge 1 commit into
Conversation
Replace writeln! with format+write_all in log_traffic_event and sign_and_log_traffic_event so each log line is written in a single write(2) syscall. POSIX O_APPEND atomicity guarantees are per-syscall; writeln! expands to two syscalls (content + newline) which Tokio tasks can interleave, producing concatenated receipts on a single line. Fixes #106. Co-authored-by: cjhoogenboom <chrishoogenboom102599@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync from sevorix-watchtower@5f187a4a12dabc241d550bfca0132482ae7811b8.