fix(LoginController): call session_regenerate_id() before authentication to prevent session fixation - #2255
Merged
Conversation
…ion to prevent session fixation PHP documentation mandates: 'Session IDs must be regenerated when user privileges are elevated, such as after authenticating. session_regenerate_id() must be called prior to setting the authentication information to $_SESSION.' Additionally, 'session_regenerate_id(true) and session_destroy() must never be called together for an active session.' The old code called destroy() -> start() -> regenerateId(true), which: 1. Violated the ordering requirement (regenerateId after auth) 2. Combined regenerateId(true) with destroy() (forbidden by PHP docs) Fix: call regenerateId(true) first (it saves session data and creates a new session ID), then set cookie parameters. No need for separate destroy() or start() calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session_regenerate_id()must be called prior to setting the authentication information to$_SESSION.'session_regenerate_id(true)andsession_destroy()must never be called together for an active session.'destroy() -> start() -> regenerateId(true), which:regenerateIdafter auth)regenerateId(true)withdestroy()(forbidden by PHP docs)regenerateId(true)first (it saves session data and creates a new session ID), then set cookie parameters. No need for separatedestroy()orstart()calls.Ref. #2213