Repository navigation
perf: lazily resolve the local timezone - #909
Open
efegokdemir wants to merge 7 commits into
Open
efegokdemir wants to merge 7 commits into
efegokdemir wants to merge 7 commits into
Conversation
efegokdemir
marked this pull request as ready for review
September 19, 2026 01:08
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
Author
|
The failing musl targets exposed a real portability issue: Validation: |
Keep release builds unchanged while avoiding native i686 socketpair ENOSYS on hosted runners. Preserve all test assertions.
Replace map_or(default, identity) with equivalent unwrap_or(default) without suppressing current Clippy warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #650.
tz(get_local_timezone())initialization with a lightweight_local()FFI function.datetime -> localsyntax and output.This follows the lightweight FFI-wrapper approach suggested in the issue discussion, without introducing general-purpose lazy evaluation.
Validation
cargo fmt --all -- --checkcargo test --workspacegit diff --checkLocal benchmark
Paired measurements of
numbat -e '1 + 1'on one Mac, using debug builds:These measurements include full process startup. The observed improvement is modest, and the benchmark does not establish statistical significance.
Opening as a draft for implementation review and CI validation.