Fix the syft install: verify the tarball under its release filename - #281
Merged
Conversation
The retried install downloaded the tarball renamed to syft.tar.gz, but sha256sum -c verifies the filename recorded inside the checksums file, so verification could never pass and every docker publish job on main failed deterministically (retried four times, identically). The docker jobs are skipped on pull requests, so the step's first execution was the post-merge main push. The tarball now keeps its original release filename and the whole script body was executed locally against the real release before this commit: checksum OK, extraction OK, binary runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the deterministic docker-publish failure on main introduced by #279: the install downloaded the release tarball renamed to
syft.tar.gz, butsha256sum -cverifies the filename recorded inside the checksums file, so verification failed with "No such file or directory" on every attempt (and the retry wrapper dutifully retried a permanent failure four times).The tarball now keeps its original release filename. Root cause of the escape: the docker jobs are skipped on pull requests, so #279's new step first executed on the post-merge main push. This time the exact script body was executed locally against the real v1.51.1 release before committing: checksum OK, extraction OK, binary runs.
Worth considering separately: running the docker job (build only, no push) on PRs that touch
.github/workflows/so workflow changes to that path cannot ship untested again.