Conversation
Chatujme.cz, Discord.bio, ReverbNation and interpals return 404 for missing users, so status_code is both correct and fail-closed. Their configured errorMsg strings no longer appear on the page, and a message rule infers "account exists" from the absence of that string — so all four currently report a hit for every username.
Switching these two to status_code also switched Sherlock from GET to HEAD, which broke them in different ways: Chatujme.cz HEAD returns 200 for every username; GET returns 404 interpals HEAD enters an infinite redirect loop; GET returns 404 Both are corrected by request_method: GET, matching the existing pattern used by Aparat, CyberDefenders and others. tests/test_validate_targets.py passes for all four sites across repeated runs.
Contributor
Automatic validation of changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chatujme.cz, Discord.bio, ReverbNation and interpals return 404 for missing users, so status_code is both correct and fail-closed.
Their configured errorMsg strings no longer appear on the page, and a message rule infers "account exists" from the absence of that string — so all four currently report a hit for every username.