fix: handle urllib3 LocationParseError (crash on usernames ending in .) - #3070
Open
SkxOverKill wants to merge 1 commit into
Open
fix: handle urllib3 LocationParseError (crash on usernames ending in .)#3070SkxOverKill wants to merge 1 commit into
SkxOverKill wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2970 — Sherlock crashes (unhandled
urllib3.exceptions.LocationParseError) when a username produces an unresolvable URL host, e.g.alice.buildshttps://alice..empretienda.com.arfor Empretienda AR.requestsdoes not wrapurllib3 LocationParseError, so it escaped the per-site error handling inget_response()and killed the entire run via arequest_future.result()exception. This converts it into a per-site "Invalid URL" error (QueryStatus.UNKNOWN) so the rest of the usernames/sites continue.Reproduction (before)
python sherlock alice.ended with:After
alice.is recorded against each site as before; the Empretienda AR site is reported as an error instead of crashing the whole search.Changes
sherlock_project/sherlock.py: handleurllib3.exceptions.LocationParseErroringet_response()alongside the other per-site errors.pyproject.toml: declare the now-directurllib3dependency.tests/test_probes.py: offline regression testtest_location_parse_error_does_not_crashasserting the exception is surfaced as an error, not re-raised.Verification
pytest -m "not online"offline suite passes (including the new regression test).ruff checkintroduces no new violations vs. HEAD baseline.