fix: --output flag writes the file without requiring --txt (#2992) - #3083
Open
Dev9269 wants to merge 1 commit into
Open
fix: --output flag writes the file without requiring --txt (#2992)#3083Dev9269 wants to merge 1 commit into
Dev9269 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2992
--output myfile.txtwithout--txtsilently created no file. The help text promises the file is written when--outputis used, but the write block was guarded exclusively byargs.output_txt.Minimal fix: the txt write block now also runs when
--outputis given (if args.output_txt or args.output:).result_filewas already computed correctly for the--outputcase, so the existingopen(result_file, "w")writes to the requested path.--folderoutputbehavior and the--csvpath are untouched; the--outputsingle-username guard (line ~734) already rejects multi-username usage, so the file can never be clobbered across usernames.