fix: treat status_code == 0 as a successfully-received response (#3027) - #3085
Open
Dev9269 wants to merge 1 commit into
Open
fix: treat status_code == 0 as a successfully-received response (#3027)#3085Dev9269 wants to merge 1 commit into
Dev9269 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3027
get_responseusedif response.status_code:to detect a successfully-received response. The truthiness test silently treatsstatus_code == 0as a failure (impossible for real HTTP, but the response object could report it), and a futureResponsereportingstatus_codeasNonewould crash the comparison.Replaced with an explicit
response is not None and response.status_code is not Nonecheck so any integer status code is treated as a received response, and the actual status semantics (200/300/400 handling) are decided downstream by the site's error metadata, unchanged.