Repository navigation
fix: repopulate tags + visibility when editing from history - #119
Merged
Merged
Conversation
applyHistoryItemToForm filled name/description/about/icon/version but left selectedTags empty and visibility at its default — rebuilding an existing app silently dropped its tags and flipped a public app back to private. Custom tags that aren't builtin chips are re-created as chips so they stay selectable. Also strip transient _about_text/_about_images in _snapshot_from_recipe: raw upload data URLs were being persisted into the history DB. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectedTags(re-creating chips for custom tags) andcurrentVisibility— previously tags were silently dropped and a public app re-published as private._snapshot_from_recipenow also strips_about_text/_about_images— raw upload data URLs were landing in the history DB.Fixes #118
Test plan
Generated with Devin