Skip to content

merge ubuntu workflows#1812

Open
shimat wants to merge 3 commits intomainfrom
merge_ubuntu]
Open

merge ubuntu workflows#1812
shimat wants to merge 3 commits intomainfrom
merge_ubuntu]

Conversation

@shimat
Copy link
Owner

@shimat shimat commented Feb 15, 2026

No description provided.

@shimat shimat self-assigned this Feb 15, 2026
@shimat shimat marked this pull request as ready for review February 15, 2026 13:22
Copilot AI review requested due to automatic review settings February 15, 2026 13:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates the separate Ubuntu 22.04 and 24.04 GitHub Actions workflows into a single matrix-based Ubuntu workflow and updates the NuGet publishing workflow to pull artifacts from the unified workflow.

Changes:

  • Merge Ubuntu 22.04 and 24.04 CI into one matrix job in ubuntu.yml and remove the dedicated ubuntu24.yml.
  • Update publish_nuget.yml to download Ubuntu artifacts from ubuntu.yml (and add a linux-x64 artifact download step).
  • Switch several packaging workflows (Ubuntu/Wasm/Linux ARM) to use a -beta version suffix during packing.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/wasm.yml Changes NuGet packing to use a -beta suffix.
.github/workflows/ubuntu24.yml Removes the standalone Ubuntu 24.04 workflow (replaced by matrix).
.github/workflows/ubuntu.yml Introduces a 22.04/24.04 matrix build and updates build/pack steps and artifact upload naming.
.github/workflows/publish_nuget.yml Updates artifact downloads to point at ubuntu.yml and adds a linux-x64 artifact download step.
.github/workflows/linux-arm.yml Changes NuGet packing to use a -beta suffix.
Comments suppressed due to low confidence (3)

.github/workflows/ubuntu.yml:26

  • The matrix value ubuntu: "22.04"/"24.04" is later interpolated into the uploaded artifact name (artifacts_ubuntu_${{ matrix.ubuntu }}), which will produce names like artifacts_ubuntu_22.04. The publish workflow currently downloads artifacts_ubuntu_22 and artifacts_ubuntu_24, so either change matrix.ubuntu to match those names (e.g., 22/24) or update the publish workflow download names to include the full version string.
    .github/workflows/ubuntu.yml:173
  • Setting BETA to -beta for the Ubuntu packages will cause the publish job’s OpenCvSharp.NupkgBetaRemover to take its if (nupkgFile.Contains("ubuntu")) branch, which does not remove the -beta prerelease suffix from the <version> in the nuspec. That means the pushed Ubuntu packages are likely to remain prerelease even after the rename step. Either keep BETA empty for the Ubuntu packages or update the beta-removal logic to strip -beta for Ubuntu packages too.
    .github/workflows/ubuntu.yml:190
  • actions/upload-artifact is uploading artifacts_ubuntu_${{ matrix.ubuntu }}, but publish_nuget.yml downloads artifacts_ubuntu_22 and artifacts_ubuntu_24. Update this artifact name (or the publish downloads) so the publish workflow can reliably find both Ubuntu artifacts after merging the workflows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +37 to +44
- name: Download linux x64 artifact
uses: dawidd6/action-download-artifact@v14
with:
github_token: ${{secrets.GITHUB_TOKEN}}
workflow: ubuntu.yml
name: artifacts_linux_x64
branch: ${{ github.ref_name }}

Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish workflow downloads an artifacts_linux_x64 artifact from ubuntu.yml, but ubuntu.yml never uploads an artifact with that name (it currently uploads only artifacts_ubuntu_*). Either upload a distinct linux-x64 artifact from the Ubuntu matrix job, or remove/adjust this download step to match what the build workflow actually produces.

Suggested change
- name: Download linux x64 artifact
uses: dawidd6/action-download-artifact@v14
with:
github_token: ${{secrets.GITHUB_TOKEN}}
workflow: ubuntu.yml
name: artifacts_linux_x64
branch: ${{ github.ref_name }}

Copilot uses AI. Check for mistakes.
Comment on lines 21 to 35
- name: Download ubuntu 22 artifact
uses: dawidd6/action-download-artifact@v14
with:
github_token: ${{secrets.GITHUB_TOKEN}}
workflow: ubuntu22.yml
workflow: ubuntu.yml
name: artifacts_ubuntu_22
branch: ${{ github.ref_name }}

- name: Download ubuntu 24 artifact
uses: dawidd6/action-download-artifact@v14
with:
github_token: ${{secrets.GITHUB_TOKEN}}
workflow: ubuntu24.yml
workflow: ubuntu.yml
name: artifacts_ubuntu_24
branch: ${{ github.ref_name }}
Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These download steps reference artifact names artifacts_ubuntu_22 / artifacts_ubuntu_24, but the merged ubuntu.yml workflow uploads artifacts_ubuntu_${{ matrix.ubuntu }} (currently 22.04 / 24.04). Align the downloaded artifact names with the ones being uploaded, otherwise the publish job will fail to download Ubuntu artifacts.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant