fix(run): preserve job dependencies when tasks are skipped#40
Merged
Conversation
stefraynaud
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
Description
When tasks were skipped via
--skipor[stages] skip, the job dependency chain between cycles was silently broken. Tasks in cycle N+1 lost their dependency on cycle N's jobs whenever cycle N was entirely skipped, allowing cycles to run out of order on the scheduler.The same issue affected sequential task groups: if task A in
[A -> B]was skipped, task B lost the dependency on the previous sequence's jobs.Root cause — three assignments in
Workflow.run()unconditionally overwrote dependency lists with an empty list when no jobs were submitted:Fix — only update each variable when jobs were actually submitted; fall back to the preserved value otherwise:
Check list
--skipis use #39CHANGES.rstapi.rst