fix: harden storefront cart state and re-resolve shop routes on navigation#406
Open
Shreyas2004wagh wants to merge 1 commit intoshopstr-eng:mainfrom
Open
fix: harden storefront cart state and re-resolve shop routes on navigation#406Shreyas2004wagh wants to merge 1 commit intoshopstr-eng:mainfrom
Shreyas2004wagh wants to merge 1 commit intoshopstr-eng:mainfrom
Conversation
|
@Shreyas2004wagh is attempting to deploy a commit to the shopstr-eng Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two storefront stability issues:
localStorage.cartcontained malformed JSONWhat was the issue
The storefront wrappers were polling
localStorage.cartand using rawJSON.parse. If the cart value was corrupted, the parse would throw and the storefront cart quantity logic could break repeatedly.The shop route pages also kept local lookup state across slug changes. In practice, client-side navigation between different
/shop/{slug}or/shop/{slug}/{page}routes could keep the old shop mounted or skip re-resolving the new slug.What this changes
JSON.parse/shop/[...shopPath]Why this matters
This makes storefront navigation more resilient:
Testing
npm test -- storefront-cart.test.ts --runInBandnpm test -- shop-route-resolution.test.tsx --runInBand