Inbound CloudEvent topic/pubsubname (and JobName) fed into non-empty require can throw mid-dispatch

[sideeffffect]

Severity: low · Category: correctness (robustness)

Evidence

• src/internal/DaprAppServer.scala:539-540 — Topic(s.asText("")) / PubSubName(s.asText("")) lack the .filter(_.nonEmpty) guard that every sibling field has (:531,533,535,538,541).
• src/internal/JobsCapabilityImpl.scala:48 — JobName(resp.getName.nn) feeds a sidecar-supplied name straight into a non-empty constructor.

Problem
Topic/PubSubName/JobName require(nonEmpty). A present-but-empty value ("") in the envelope throws IllegalArgumentException inside the handler → 500 / RETRY instead of graceful handling. Defensive (the sidecar normally populates these), but it's an in-block asymmetry with the other fields.

Suggested fix
Mirror the sibling fields: Option(env.get("topic")).map(_.asText("")).filter(_.nonEmpty).map(Topic(_)).getOrElse(default) (same for pubsubname); only wrap JobName when non-empty.

[sideeffffect]

Confirmed the asymmetry: in parseCloudEvent (DaprAppServer.scala:539-540), topic and pubSubName go straight into Topic(s.asText("")) / PubSubName(s.asText("")) while every sibling field (:531,533,535,538,542) guards with .filter(_.nonEmpty). Since Topic/PubSubName/JobName all require(nonEmpty), a present-but-empty value throws IllegalArgumentException inside the handler thread → 500 / RETRY rather than falling back.

Fix — mirror the siblings exactly (note the .filter goes before the constructor, and the fallback is the default, not ""):

topic = Option(env.get("topic"))
  .map(_.asText("")).filter(_.nonEmpty).map(Topic(_)).getOrElse(defaultTopic),
pubSubName = Option(env.get("pubsubname"))
  .map(_.asText("")).filter(_.nonEmpty).map(PubSubName(_)).getOrElse(defaultPubsubName),

For JobsCapabilityImpl.scala:48, JobName(resp.getName.nn) takes the sidecar-supplied name. There's no sensible default for a returned job, so guard rather than substitute:

name = JobName(
  Option(resp.getName).map(_.nn).filter(_.nonEmpty)
    .getOrElse(throw IllegalStateException("Dapr returned a job with no name"))),

or surface it as a decode/Left failure consistent with the rest of that method.

Notes:

• This is defensive (a well-behaved sidecar populates these), so low priority, but it removes a class of mid-dispatch IllegalArgumentException that's indistinguishable from a real handler failure.
• The CloudEvent change is purely local and behavior-preserving for the normal non-empty case, so it's safe to land on its own.